Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark in-active files as fully read before skipping them #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

max-frank
Copy link

This PR fixes #288

Note that this is missing a unit test to check if consecutive runs with the settings described in the issue properly halt.
Sadly I am not sure how to properly check for logstash execution halt within a timeout and as such did not write the unit test myself.

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 26, 2021

❌ Author of the following commits did not sign a Contributor Agreement:
55f1907

Please, read and sign the above mentioned agreement if you want to contribute to this project

@max-frank max-frank force-pushed the fix-exit-after-read-not-working-if-files-already-read branch from 3c5a05b to ffb0f2c Compare March 26, 2021 10:50
@max-frank max-frank force-pushed the fix-exit-after-read-not-working-if-files-already-read branch from ffb0f2c to 55f1907 Compare March 26, 2021 11:25
@max-frank
Copy link
Author

sincdb clean up test failure suspected to be unrelated to the code changes of this PR. I am unable to find the cause of the problem also see #287 which encounters the same failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit after read does not work if all files have already been read
2 participants