Backport to 5.x of fixes from more recent branches #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes up some issues with logging, where the batch size was calculated incorrectly. Fixes logstash-plugins#216
Log errors encountered when sending messages to Kafka at warn, rather than debug, to improve the visibility of errors such as 'RecordTooLargeException.' Fixes logstash-plugins#177 Fixes logstash-plugins#179
robbavey
force-pushed
the
backports_5_x
branch
from
162c40f to
2828bd9
Compare
Fixed incorrect millisecond to second conversion for retry_backoff_ms logstash-plugins#216 Fixed unnecessary sleep after exhausted retries logstash-plugins#166 Changed Kafka send errors to log as warn logstash-plugins#179
robbavey
force-pushed
the
backports_5_x
branch
from
2828bd9 to
6ac4b98
Compare
robbavey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incorrect millisecond to second conversion for retry_backoff_ms #216
Fixed unnecessary sleep after exhausted retries #166
Changed Kafka send errors to log as warn #179