Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed expected datatype of request_timeout_ms option to number #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed expected datatype of request_timeout_ms option to number #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 9.0.0
- Changed expected datatype of `request_timeout_ms` option to number
[#222](https://github.com/logstash-plugins/logstash-output-kafka/pull/222)

## 8.0.1
- Fixed issue with unnecessary sleep after retries exhausted [#216](https://github.com/logstash-plugins/logstash-output-kafka/pull/216)

Expand Down
4 changes: 2 additions & 2 deletions docs/index.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ This plugin supports the following configuration options plus the <<plugins-{typ
| <<plugins-{type}s-{plugin}-metadata_max_age_ms>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-receive_buffer_bytes>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-reconnect_backoff_ms>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-request_timeout_ms>> |<<string,string>>|No
| <<plugins-{type}s-{plugin}-request_timeout_ms>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-retries>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-retry_backoff_ms>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-sasl_kerberos_service_name>> |<<string,string>>|No
Expand Down Expand Up @@ -266,7 +266,7 @@ The amount of time to wait before attempting to reconnect to a given host when a
[id="plugins-{type}s-{plugin}-request_timeout_ms"]
===== `request_timeout_ms`

* Value type is <<string,string>>
* Value type is <<number,number>>
* There is no default value for this setting.

The configuration controls the maximum amount of time the client will wait
Expand Down
2 changes: 1 addition & 1 deletion lib/logstash/outputs/kafka.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
# for the response of a request. If the response is not received before the timeout
# elapses the client will resend the request if necessary or fail the request if
# retries are exhausted.
config :request_timeout_ms, :validate => :string
config :request_timeout_ms, :validate => :number
# The default retry behavior is to retry until successful. To prevent data loss,
# the use of this setting is discouraged.
#
Expand Down
2 changes: 1 addition & 1 deletion logstash-output-kafka.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Gem::Specification.new do |s|

s.name = 'logstash-output-kafka'
s.version = '8.0.1'
s.version = '9.0.0'
s.licenses = ['Apache-2.0']
s.summary = "Writes events to a Kafka topic"
s.description = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
Expand Down