Add support for the LPUSH command as a list operation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LPUSH command inserts at the head of the list, as opposed to RPUSH which inserts at the head of the list. The default list operation remains RPUSH. However, LPUSH may be set via the list_operation configuration option. While here, fix documentation about the minimum version for RPUSH/LPUSH support, which is 1.0.0 according to Redis documentation.
|
Any community members that can help review this PR ? |
|
Is there a chance this will ever get reviewed? |
|
What is needed to have this PR verified? |
|
HI, we also have need of this - for sidekiq integration. Any chance we can get this into the plugin? |
|
For what it's worth, the change looks simple and effective, and we'd love to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the LPUSH command. There are scenarios where inserting at the head of the list rather than the tail is needed, especially considering operations like RPOPLPUSH have no equivalent for working with the head of the list (LPOPLPUSH does not exist for instance).
The default list operation remains RPUSH. However, LPUSH may be set via
the new
list_operationconfiguration option. This means that compatibility is preserved.While here, fix documentation about the minimum version for RPUSH/LPUSH
support, which is 1.0.0 according to Redis documentation.