Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Longhorn toolbox CLI #33

Merged
merged 31 commits into from
Jun 19, 2024
Merged

feat: Longhorn toolbox CLI #33

merged 31 commits into from
Jun 19, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7927

What this PR does / why we need it:

Add common functions to be used by Longhorn Toolbox CLI.

Special notes for your reviewer:

None

Additional documentation or context

None

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 91.35338% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.19%. Comparing base (103c7d6) to head (f4f499d).

Files Patch % Lines
io/file.go 81.39% 5 Missing and 3 partials ⚠️
kubernetes/kubernetes.go 50.00% 4 Missing ⚠️
kubernetes/daemonset.go 92.10% 2 Missing and 1 partial ⚠️
kubernetes/serviceaccount.go 91.66% 2 Missing and 1 partial ⚠️
kubernetes/pod.go 90.47% 1 Missing and 1 partial ⚠️
kubernetes/clusterrole.go 96.77% 1 Missing ⚠️
kubernetes/clusterrolebinding.go 96.77% 1 Missing ⚠️
kubernetes/configmap.go 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   76.69%   79.19%   +2.49%     
==========================================
  Files          24       32       +8     
  Lines        1223     1485     +262     
==========================================
+ Hits          938     1176     +238     
- Misses        181      198      +17     
- Partials      104      111       +7     
Flag Coverage Δ
unittests 79.19% <91.35%> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@james-munson james-munson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working, but one small comment so far.

longhorn/longhorn.go Outdated Show resolved Hide resolved
io/file.go Show resolved Hide resolved
derekbit
derekbit previously approved these changes Jun 19, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

@c3y1huang We can merge it after resolving the conflicts. Thank you.

Signed-off-by: Chin-Ya Huang <[email protected]>
@derekbit derekbit merged commit 2133a7e into longhorn:main Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants