Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove hyphens from UUID before truncating it #39

Merged
merged 1 commit into from
May 14, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8551

What this PR does / why we need it:

Remove hyphens from UUID before truncating it in RandomID()

Special notes for your reviewer:

Additional documentation or context

Remove hyphens from UUID before truncating it in RandomID()

Longhorn 8551

Signed-off-by: Derek Su <[email protected]>
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (e68a6cd) to head (b2c25d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files          26       26           
  Lines        1361     1361           
=======================================
  Hits          998      998           
  Misses        254      254           
  Partials      109      109           
Flag Coverage Δ
unittests 73.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekbit derekbit requested a review from c3y1huang May 14, 2024 06:51
@derekbit derekbit merged commit 3514596 into longhorn:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants