fix: need to check the device path exist first before checking filesystem type and doing formatting

[PhanLe1010]

longhorn/longhorn#10416

[coderabbitai]

Walkthrough

The changes introduce an error handling enhancement in the nodeStageMountVolume method of the NodeServer struct. An existence check for the device at devicePath is added before proceeding with formatting and mounting. If the device does not exist, the function returns an error immediately, modifying the control flow to prevent further operations that assume the device's existence.

Changes

File(s)	Summary
csi/node_server.go	Added a check using os.Stat to verify the existence of devicePath. Returns a detailed error if the device is not present, preventing further formatting and mounting operations.

Sequence Diagram(s)

sequenceDiagram
    participant NS as NodeServer
    participant FS as Filesystem (os.Stat)
    participant M as Mount Module

    NS->>FS: Check devicePath existence
    FS-->>NS: Return device status (exists or error)
    alt Device does not exist
        NS->>NS: Return error with detailed message
    else Device exists
        NS->>M: Proceed with format and mount operations
        M-->>NS: Return operation result
    end

Loading

Suggested reviewers

• innobead
• ChanYiLin
• c3y1huang

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebff941 and f56e330.

📒 Files selected for processing (1)

• csi/node_server.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• csi/node_server.go

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build binaries
• GitHub Check: Summary

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[derekbit]

LGTM

[derekbit]

@mergify backport v1.8.x v1.7.x

[mergify]

backport v1.8.x v1.7.x

✅ Backports have been created

• #3580 fix: need to check the device path exist first before checking filesystem type and doing formatting (backport #3579) has been created for branch v1.8.x
• #3581 fix: need to check the device path exist first before checking filesystem type and doing formatting (backport #3579) has been created for branch v1.7.x