fix(deps): update Dockerfile to SPDK longhorn-v24.09 branch #239
Conversation
WalkthroughThe changes in the pull request primarily involve updating the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
Dockerfile.dapper(1 hunks)
🔇 Additional comments (2)
Dockerfile.dapper (2)
Line range hint 45-57: Verify SPDK build configuration for v24.09
The build configuration uses architecture-specific settings and disables several features. Please verify:
- If the new SPDK version requires any additional build flags
- If the architecture-specific settings (
nehalemfor amd64,nativefor arm64) are still optimal - If the disabled features (
tests,unit-tests,examples,nvme-cuse) are still intended to be disabled
#!/bin/bash
# Description: Check for build configuration changes in new SPDK version
# Expected: Build flags should be compatible with v24.09
# Clone and check configure script changes
cd /tmp
git clone https://github.com/longhorn/spdk.git
cd spdk
git checkout 10463b5c13b454e173707628b9eac608081f5082
# Check configure script help and defaults
./configure --help
grep -r "target-arch" .
grep -r "DPDKBUILD_FLAGS" .
# Clean up
cd /tmp
rm -rf spdkLine range hint 17-20: Verify dependency compatibility with new SPDK version
Please ensure that the current versions of dependencies (libjson-c, nvme-cli, and go-spdk-helper) are compatible with the new SPDK version.
derekbit
force-pushed
the
longhorn-v24.09
branch
from
ec30fcf
to
661a538
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
========================================
+ Coverage 8.39% 8.43% +0.04%
========================================
Files 21 21
Lines 7150 7150
========================================
+ Hits 600 603 +3
+ Misses 6470 6468 -2
+ Partials 80 79 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
DamiaSan
changed the title
Longhorn 9700 Signed-off-by: Damiano Cipriani <[email protected]>
DamiaSan
force-pushed
the
longhorn-v24.09
branch
from
661a538
to
b318dc7
Compare
Longhorn 9700
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9700
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context