Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about storage class defaults #1047

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

james-munson
Copy link
Contributor

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#10253

What this PR does / why we need it:

Clarify the relation between storage class parameters and global settings in volume creation. Also, fix some example YAML formatting.

Special notes for your reviewer:

If this is satisfactory, I will duplicate it for all active releases.

Additional documentation or context

@james-munson james-munson requested a review from a team as a code owner January 28, 2025 22:42
@james-munson james-munson requested review from derekbit and removed request for jhkrug and jillian-maroket January 28, 2025 22:42
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 718fcf0
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/67a100c3fcd99e000802851a
😎 Deploy Preview https://deploy-preview-1047--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jhkrug
jhkrug previously approved these changes Jan 30, 2025
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny tweak for your consideration. Otherwise, LGTM.

@james-munson
Copy link
Contributor Author

Propagated to 1.6.x, 1.7.x, 1.8.x, and 1.9.0.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@innobead innobead merged commit df4fac9 into longhorn:master Feb 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants