-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about storage class defaults #1047
Conversation
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny tweak for your consideration. Otherwise, LGTM.
858ebe0
to
db8884d
Compare
Signed-off-by: James Munson <[email protected]>
db8884d
to
718fcf0
Compare
Propagated to 1.6.x, 1.7.x, 1.8.x, and 1.9.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#10253
What this PR does / why we need it:
Clarify the relation between storage class parameters and global settings in volume creation. Also, fix some example YAML formatting.
Special notes for your reviewer:
If this is satisfactory, I will duplicate it for all active releases.
Additional documentation or context