Switch to Anarchy when the current government is lost #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the technology for the current government is lost, the game used to pick some government at random. Be more punitive and always switch to Anarchy. This is more consistent with other government changes. Closes longturn#2047.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Dec 29, 2023
|
There is one more :p, I thought you'll fix in both places at once 😛 |
lmoureaux
force-pushed
the
feature/gov-tech-loss-starts-anarchy
branch
from
81e2d24 to
aefe0f1
Compare
Started this PR too long ago, I don't remember what it's doing :D |
|
I didnt test it (I dont know how to, dont have a save game where I lose a tech), I just read though the code cuz it caught my attention. LGTM. I just wanted to check if there is specific problems with not defining a gov during revolution which caused them to chose random government in the first place. But looks like a gov during revolution is compulsory and the game raises an error otherwise, so I think this should work as intended. |
|
Also looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the technology for the current government is lost, the game used to pick some government at random. Be more punitive and always switch to Anarchy. This is more consistent with other government changes.
Closes #2047.