fix

lonnik · Jun 24, 2024 · 71a5ef2 · 71a5ef2
1 parent a0c79be
commit 71a5ef2
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 20 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -50,11 +50,9 @@ jobs:
         run: |
           mkdir -p ./secrets
           echo "${{ secrets.TEST_FIREBASE_SERVICE_ACCOUNT_KEY_BASE64 }}" | base64 -d > ./secrets/firebase_service_account_key.json
-          ls -la ./secrets
 
       - name: Run tests
         run: |
-          ls -la ./secrets
           TEST_FIREBASE_API_KEY=${{ secrets.TEST_FIREBASE_API_KEY }} make test
 
   ci:

diff --git a/services/server/cmd/main.go b/services/server/cmd/main.go
@@ -17,6 +17,7 @@ import (
 
 var (
 	firebaseCredentialsFilename = "./secrets/firebase_service_account_key.json"
+	logFilename                 = "logfile.log"
 )
 
 func main() {
@@ -36,7 +37,7 @@ func main() {
 	googleGeocodeRepo := googlegeocode.NewGoogleGeocodeRepo(googleGeocodeApiKey)
 
 	// logger configuration
-	logFile, err := os.Create("logfile.log")
+	logFile, err := os.Create(logFilename)
 	exitOnError(err)
 	defer logFile.Close()
 

diff --git a/services/server/pkg/controllers/address.go b/services/server/pkg/controllers/address.go
@@ -6,7 +6,6 @@ import (
 	"spaces-p/pkg/errors"
 	"spaces-p/pkg/models"
 	"spaces-p/pkg/services"
-
 	"spaces-p/pkg/utils"
 
 	"github.com/gin-gonic/gin"

diff --git a/services/server/pkg/repositories/redis_repo/redis.go b/services/server/pkg/repositories/redis_repo/redis.go
@@ -21,9 +21,9 @@ func NewRedisRepository(redisClient *redis.Client) *RedisRepository {
 
 func (repo *RedisRepository) DeleteAllKeys() error {
 	const op errors.Op = "redis_repo.RedisRepository.DeleteAllKeys"
-	isDevelopmentTestEnv := os.Getenv("ENVIRONMENT") == "development" || os.Getenv("ENVIRONMENT") == "test"
+	isDevOrTestEnv := os.Getenv("ENVIRONMENT") == "development" || os.Getenv("ENVIRONMENT") == "test"
 
-	if !isDevelopmentTestEnv {
+	if !isDevOrTestEnv {
 		return errors.E(op, common.ErrOnlyAllowedInDevEnv)
 	}
 

diff --git a/services/server/pkg/utils/slice.go b/services/server/pkg/utils/slice.go
@@ -9,17 +9,3 @@ func SliceContains[T string | int | bool](s []T, item T) bool {
 
 	return false
 }
-
-type Predicate[T any] func(T) bool
-
-func FilterSlice[T any](s []T, predicate Predicate[T]) []T {
-	var filtered []T
-
-	for _, item := range s {
-		if predicate(item) {
-			filtered = append(filtered, item)
-		}
-	}
-
-	return filtered
-}