-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace multiselectfield #1072
base: develop
Are you sure you want to change the base?
Replace multiselectfield #1072
Conversation
6e59532
to
332a326
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Can you confirm that other checkbox choices, like the big list of languages people can choose when creating/modifying a Child, are not affected by this? Just wasn't clear from what you wrote above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that other checkbox choices, like the big list of languages people can choose when creating/modifying a Child, are not affected by this? Just wasn't clear from what you wrote above.
332a326
to
9552222
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mekline I can confirm that the US ethnicity question is the only one that uses @okaycj happy to approve this pending the fix to circleci build-and-test 🙂 Also I noticed that the question text that is currently live on staging/develop looks different to that in your screenshot above: Note the slight difference in question text:
And the help text below the question, which is missing in the screenshot above:
But it doesn't look like you've changed/removed the question or help text in this PR, so maybe the screenshot above (from Jan 25th) is just out of date? |
To get ready to update Django (#1051), the django-multiselectfield package needs to be removed. By all accounts, the library hasn't been updated since the beginning of 2021.
In order to replace the multiselect field with a bit field, the string values had to be compared to the list of choices and get the index. The index is masked and then or'd with all selections for that field.
The US Ethnicity field is the only field that needed to be migrated away from multiselect.