Exit URL fix (#109)

* modify on_finish logic to throw error if both sequence and data are empty * update surveys version in package lock * add changeset * Small change to tests and sequence error logic * Fix exit url interrupting Response patch * Changeset --------- Co-authored-by: Becky Gilbert <[email protected]>
lookit · Nov 6, 2024 · 0d02095 · 0d02095
1 parent 7e4c63e
commit 0d02095
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.changeset/thin-oranges-collect.md b/.changeset/thin-oranges-collect.md
@@ -0,0 +1,5 @@
+---
+"@lookit/lookit-initjspsych": patch
+---
+
+Fix the exit URL interupting final Response patch
diff --git a/packages/lookit-initjspsych/src/utils.ts b/packages/lookit-initjspsych/src/utils.ts
@@ -74,13 +74,12 @@ export const on_finish = (
       userFunc(data);
     }
 
-    await Api.finish();
     await Api.updateResponse(responseUuid, {
       exp_data,
       sequence: [...sequence, `${last_exp.trial_index}-${last_exp.trial_type}`],
       completed: true,
-    });
-
-    exit_url && window.location.replace(exit_url);
+    })
+      .then(() => Api.finish())
+      .then(() => exit_url && window.location.replace(exit_url));
   };
 };