Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AWS S3 env var names #55

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Change AWS S3 env var names #55

merged 2 commits into from
Oct 9, 2024

Conversation

becky-gilbert
Copy link
Contributor

This PR changes the AWS S3 environment variable names used for uploading to the jsPsych video bucket. We used the same environment variable names that are used for EFP (RecordRTC) video uploading, so we need different ones to avoid conflicting variable names in the lookit-api environment.

For local development - remember to also change the variable names in packages/data/.env.

Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: a4b87fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@lookit/data Patch
@lookit/lookit-initjspsych Patch
@lookit/record Patch
@lookit/surveys Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@becky-gilbert becky-gilbert self-assigned this Oct 5, 2024
@becky-gilbert becky-gilbert requested a review from okaycj October 5, 2024 00:32
Copy link
Collaborator

@okaycj okaycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but doesn't this need a changeset?

@becky-gilbert becky-gilbert requested a review from okaycj October 7, 2024 17:12
@becky-gilbert becky-gilbert merged commit f2cd2a8 into main Oct 9, 2024
2 checks passed
@becky-gilbert becky-gilbert deleted the change-s3-var-names branch October 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants