-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mustache with handlebars. #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e3fd8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
becky-gilbert
approved these changes
Oct 8, 2024
okaycj
added a commit
that referenced
this pull request
Oct 9, 2024
* Remove mustache dependency * Remove mustache config * Rename template extensions * Remove mustache code and replace with handlebars * Format changes * Fixed issue with import * changset
okaycj
added a commit
that referenced
this pull request
Oct 10, 2024
* Move/New templates * Remove unused template * Change to Rollup processing images * Update tests * Add dependencies * Have prettier handle mustache files * Video consent trial * Update to templates/move template from EFP * Added error for undefined types in jsPsych timeline. * Update style * Remove record icon from webcam feed * Add replace webcam feed function with record feed function * Update tests * Replace mustache with handlebars. (#56) * Remove mustache dependency * Remove mustache config * Rename template extensions * Remove mustache code and replace with handlebars * Format changes * Fixed issue with import * changset * Force mkdocs to serve on port 8888 * Change the docs theme * Update python packages * Add documentation for video consent trial * For HTML in markdown * changeset * Add example, add locale param, Remove references to other consent templates * Update copy * Remove circular dependency * Fix formatting issues * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're moving from mustache to Handlebars. This will allow us to drop EFP templates into our new jsPsych trials.