add FreeBSD support #14
Conversation
|
Tested on: If you plan to expand your module to work with several distributions, it is possible to use the 'case' construction is more conveniently, for example: https://github.com/saz/puppet-memcached/blob/master/manifests/params.pp#L4 However, in my patch I inherit |
changes for FreeBSD are trivial and mainly relate to
an alternative path to configuration and executable files.
So, the standard way for 3rd-party config files in FreeBSD:
/usr/local/etc{/rsnapshot}
and for binaries:
/usr/local
Also, define @cmd_rsnapshot in cron.erb via config_cmd_rsnapshot
changes for FreeBSD are trivial and mainly relate to
an alternative path to configuration and executable files.
So, the standard way for 3rd-party config files in FreeBSD:
/usr/local/etc{/rsnapshot}
and for binaries:
/usr/local
Also, define @cmd_rsnapshot in cron.erb via config_cmd_rsnapshot
|
Hi Oleg, thank you for your work! I will gladly accept your PR once we manage to get the travis checks passing. I think it should suffice to set the puppet gem version in .travis.yml to something < 5.0? I'm not actively using puppet anymore, could you please check that? Thank you! |
|
Actually, it looks like we should rather bump the rvm version in .travis.yml. |
|
I created a PR on your master with the according fixes. |
Fix travis checks
|
Hi Oleg, thanks for merging the changes. So, the installation problem seems to be solved, however, the builds still fail. Not sure why though. This is the last successful build, where I just changed what you merged Your changes seem to break something, but I can't figure out why. Maybe you can look into this? |
|
Yes, it looks strange to me also. I will try to look at it in the next week. Thanks a lot for your help/tips. |
| @@ -190,19 +190,21 @@ | |||
| # create cron files for each backup level | |||
| # merge possible cron definitions to one | |||
| $real_cron = deep_merge($rsnapshot::params::cron, $rsnapshot::cron, $hash[cron]) | |||
| $cmd_rsnapshot = pick($rsnapshot::cmd_rsnapshot, $rsnapshot::params::config_cmd_rsnapshot) | |||
There was a problem hiding this comment.
I can't find $rsnapshot::cmd_rsnapshot (no $cmd_rsnapshot in init.pp). Seems to produce warnings in the test suite.
@loomsen For the record, if you are not using Puppet anymore and maintaing this module is low priority for you, you may consider migrating the project to voxpupuli. I guess that beyond this pull request, more changes would be appreciable by the community (e.g. switching from params.pp to Hiera; switching from erb to epp templates; etc). I am not using rsnapshot and reached this PR via private mail from @olevole, but would be pleased to help if some guidance is needed. |
|
@loomsen I am moving and will not be able to actively assist in the next weeks. I pinged the #voxpupuli people on IRC and linked to this issue. |
|
@loomsen I've sent you a github invitation. After you accept, you should be able to transfer repository ownership to VP. Any questions, could you drop by on IRC or slack? Many thanks, |
Thank you @alexjfisher, I'm pretty busy atm, but I will try and find some time over the weekend. I'll text you guys up on IRC then. Regards |
|
@olevole @alexjfisher Sorry for the "late" reply, life kind of got in my way. I'm totally out of puppet development, and would be more than happy to migrate this module now. If any of you guys are still around and willing to help, ping me please. |
@loomsen Sure. But see my comment #16 (comment) At the moment, very few of our modules use the PDK and those that do are in a bit of a limbo state whilst we figure out what the release workflow should look like. |
changes for FreeBSD are trivial and mainly relate to
an alternative path to configuration and executable files.
So, the standard way for 3rd-party config files in FreeBSD:
/usr/local/etc{/rsnapshot}
and for binaries:
/usr/local
Also, define @cmd_rsnapshot in cron.erb via config_cmd_rsnapshot