Dev master #2
Open
Dev master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
reviewed
May 18, 2023
| *(COMMON) | ||
| . = ALIGN(16); | ||
| _bss_end = .; | ||
| } | ||
|
|
||
| .rela.dyn : { *(.rela.dyn) } | ||
| . = ALIGN(4096); |
There was a problem hiding this comment.
这些为啥像是 4KiB 对齐？如果意图是对齐到“页”的话，按照 Linux 源码，最大 64KiB，常用 16KiB。
（比较蛋疼的是 UEFI 规范没提使用多大的页，估计是因为 LoongArch UEFI 应用的初始执行环境是物理地址映射吧，不需要分页。）
There was a problem hiding this comment.
主要是对齐，以解决RWX警告问题。
Arm64的做法是由于上游binutils 2.38 支持了 efi-app-aarch64，所以 crt0.S 和 lds 链接脚本做了大量修改，而LA和Riscv还没有这个特性的支持，所以参考Riscv的改法做了处理，主要是把相关的segment对齐并分离，以避免链接时警告（上游不接受改LDFLAGS的解法）。
There was a problem hiding this comment.
其它架构看起来都是4k对齐，不知道LA上是否应该选择其它大小来对齐，比如16k?
Added CHAR8, CHAR16, WCHAR and VOID type definitions for LoongArch
Binutils 2.41 now supports efi-app-loongarch64, so to use this we must add a dummy reloc section and remove the PE header definition from crt0 as this will conflict with the version added by objcopy Signed-off-by: Xiaotian Wu <[email protected]>
|
@loongarch64/dev-team 现在使用了 efi-app-loongarch64 来编译，各位可以测试一下。shim我测试能编译运行了 |
Signed-off-by: Xiaotian Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loongarch64/dev-team
看看现在这个好没好，可以测试一下systemd、fwupd等软件