Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to build on Windows Qt6. #1727

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Fixes to build on Windows Qt6. #1727

merged 5 commits into from
Oct 6, 2024

Conversation

oursland
Copy link

@oursland oursland commented Oct 6, 2024

I believe the issue was ultimately a difference in the version of CMake used the in the builds. Standardizing on cmake==3.28.3 results in builds on all platforms, whereas the previous Windows Qt6 build was utilizing cmake==3.30.3 which appears to have issues on Windows.

@github-actions github-actions bot added the :octocat: label Oct 6, 2024
@oursland
Copy link
Author

oursland commented Oct 6, 2024

@wwmayer Do you know what is going on here? https://github.com/oursland/FreeCAD/actions/runs/11197400337/job/31127324103#step:4:1306

It is only affecting these Win-64 builds with Qt6 with a strange failure that I don't quite understand, but succeeds on all other platforms including Win-64 builds with Qt5.

@wwmayer
Copy link

wwmayer commented Oct 6, 2024

You should try the build with Wm4TRational.inl taken from FreeCAD upstream because the code contains some flaws that has been reported by some code checkers like PVS Studio.

@looooo looooo merged commit 30d7ce4 into looooo:pixi Oct 6, 2024
@oursland
Copy link
Author

oursland commented Oct 6, 2024

@wwmayer It is building using src\Mod\Mesh\App\WildMagic4\Wm4TRational.inl, which is causing the issue.

A search of the forums indicate this error has been encountered before, but the cause was somewhat unrelated. Sadly, the solution for this issue isn't posted, so I'm a little confused as to the cause of the issue and how to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants