Added optional POST callback #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an optional paramater for `get_auth_link` generator function, to allow `response_mode=form_post` as an optional query parameter - This allows LINE Notify server to directly send POST request to callback URL instead of URL redirection From API docs: By assigning "form_post", sends POST request to redirect_uri by form post instead of redirecting Extended specifications: https://openid.net/specs/oauth-v2-form-post-response-mode-1_0.html We recommend assigning this to prevent code parameter leaks in certain environments
|
Thanks for your contribution :) Could you add a test case for this change? It would be helpful for the developer~ (and please check CI 🙏) |
|
Surely, it wasn't showing me CI as I am new to GitHub, now it is. |
maybe you can copy my test function as new test case~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_auth_linkgenerator function, to allowresponse_mode=form_postas an optional query parameterFrom API docs:
By assigning "form_post", sends POST request to redirect_uri by form post instead of redirecting
Extended specifications: https://openid.net/specs/oauth-v2-form-post-response-mode-1_0.html
We recommend assigning this to prevent code parameter leaks in certain environments