Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Feature : add Expand button for wide terminal and compose editor panels #678

Closed
wants to merge 12 commits into from

Conversation

YoanAncelly
Copy link

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR enhances the terminal expansion functionality across the application. The main changes include:

  1. Added a wide terminal modal view in Terminal.vue component with improved UI/UX
  2. Implemented an expand button in Compose.vue for better code editing experience
  3. Updated socket handling in socket.ts to support multiple terminal instances

Fixes #(no specific issue number provided)

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generate no new warnings

Technical Details

The changes include:

Terminal Component (Terminal.vue)

  • Added expandable terminal view with modal overlay
  • Implemented responsive terminal sizing
  • Added button to toggle wide terminal view
  • Improved terminal UI with header controls

Compose View (Compose.vue)

  • Added expand functionality for better code editing
  • Implemented modal view for expanded editor
  • Maintained terminal state during expansion

Socket Management (socket.ts)

  • Updated terminal mapping to support multiple instances
  • Enhanced socket binding for expanded terminal views
  • Improved terminal event handling

These changes improve the overall user experience by providing more flexible and usable terminal and code editing interfaces while maintaining stability and performance.

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

zen_usMERnRlCd.mp4

Yoan Ancelly added 12 commits December 2, 2024 23:38
…maintainability

✨ (Base.Dockerfile): update Node.js version to 18.17.1-bookworm-slim due to upstream bug
✨ (Base.Dockerfile): add support for ARM architectures by setting NODE_OPTIONS
✨ (Base.Dockerfile): install additional dependencies, including build-essential, python3-full, and python3-pip
✨ (Base.Dockerfile): install Node.js global packages with specific versions for better compatibility
@YoanAncelly YoanAncelly closed this Dec 9, 2024
@YoanAncelly
Copy link
Author

Currently working on my own version of dockge

@mdeeter
Copy link

mdeeter commented Dec 14, 2024

@YoanAncelly what's the image to use for your version?

@YoanAncelly
Copy link
Author

YoanAncelly commented Dec 14, 2024

@mdeeter It's yoanancelly/dockge:beta atm

Soon i'll put the expand on yoanancelly/dockge:latest

It's on DockerHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants