-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Remote header auth #1731
base: master
Are you sure you want to change the base?
Conversation
I think this maybe a similar pull request: #474. |
#474 looks pretty inactive and would probably have a bunch of merge conflicts. This PR seems to be a bit more developed so I would be tempted to say go with this one when it is ready. |
@sevmonster at the moment the code in this PR still relay on the internal user. And I had too change the default admin to my own username to get it working with an SSO. I'm not sure if we can bypass the whole internal user thing as it is used by some mechanisms that relay on some info like a userId or userName. This is why this is also still a draft PR, any feedback on that is absolutely welcome! |
668b5cc
to
6d40d30
Compare
6d40d30
to
c13182f
Compare
Just a reminder, if the feature is finished, remember to click "Ready for Review". |
@louislam Too me this can be implemented, but SSO is mainly based on multi user. The other side it to disable all Uptime Kuma user management when using SSO. (introducing "multi user"). I'm happy to update and test to get it up-to-date with other features. But then it needs a sidenote about the username change and that it only works with 1 user SSO. |
5093c9e
to
c14e425
Compare
4fe582c
to
5d27911
Compare
c809e4f
to
50f2b63
Compare
555972d
to
1570d1e
Compare
dbcf008
to
9c6ec48
Compare
4f26422
to
a60090a
Compare
a60090a
to
837276f
Compare
The same as #4751, this is blocked by #3571 which has slotted into the The current |
I’ll update the branch. |
As there is no user management at the moment.
837276f
to
49edf0d
Compare
Description
This raises the question if we want to auto generate users. But for now I've ignored that part
npm run change-username
Disabled Auth
orRemote-User
headers.Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Small cosmetic change to settings page.