-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RetroAchievements plugin #1620
Open
LuanRoger
wants to merge
13
commits into
lowlighter:master
Choose a base branch
from
LuanRoger:retroachievements-plugin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request seems to be inactive and will be automatically closed in a few days if it remains without any activity. |
Not reviewed yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created the RetroAchievements plugin for
metrics
, using the RetroAchievements's official API.It follows the style and layout of the Steam plugin, and here it's what I have done so far. I'm opening the PR just to track the checks or feedback.
I've seen that
metrics
will launch the 4.0 soon, but since there's no release date to it, the changes could be merged and I will do the migrations by my self when the new version's out, fixing any breaking changes and migrating other aspects to fit the new specs.Render output
This output was generated by my
metrics
action, using this brench as reference.Ready to merge?
metadata.yml
name
is set with an unused emoji and plugin namecategory
is set tocommunity
examples
contains links towards a rendered output hosted by youauthors
contains my GitHub usernamesupports
list which account type are supportedscopes
are correctly listed with their associated names on GitHub (leave an empty array if not applicable)inputs
are correctly filledindex.mjs
respects the plugins guidelinesshowachievements
isno
classic
is available)tests/mocks
... have been createdapp.placeholder.js
has been updated for preview from web instancesexamples.yml
contains workflows examples (at least one is required)skip: true
has been set forprod
attribute in each testnpm run linter
yields no errorsREADME.md
eventually describes complex setup or options (if applicable)