Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #218 #219

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fixes #218 #219

merged 2 commits into from
Feb 7, 2024

Conversation

mfann-or
Copy link
Contributor

@mfann-or mfann-or commented Jan 23, 2024

Description

Updated the backslash to a forward-slash for the $spn var

Fixes the same error outlined here

How Has This Been Tested?

Tested on local environment with AD

Types of changes

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf0e221) 93.68% compared to head (53eea99) 93.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          64       64           
  Lines        2202     2202           
=======================================
  Hits         2063     2063           
  Misses        139      139           
Flag Coverage Δ
sanity 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowlydba
Copy link
Owner

Thanks for the bug fix! It looks good. Can you just add a change fragment (example) so this change gets logged in the changelog?

@lowlydba lowlydba merged commit 13566b6 into lowlydba:main Feb 7, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lowlydba.sqlserver.spn - $spn is in the wrong format
3 participants