Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed login status to be more accurate #267

Closed
wants to merge 1 commit into from
Closed

fix: changed login status to be more accurate #267

wants to merge 1 commit into from

Conversation

lowlydba
Copy link
Owner

@lowlydba lowlydba commented Oct 6, 2024 •
edited
Loading

Description

When a password is included for a login, only set the result changed to true if the password actually changed. dbatools provides the PasswordChanged boolean upstream that can be used to determine this after the login has been adjusted.

How Has This Been Tested?

Types of changes

Checklist:

@lowlydba lowlydba closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Tasks using login module keeps returning changed true even when login already present
1 participant
@lowlydba