Fix URL parsing without port #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jan 9, 2025
src/pog.gleam
Outdated
| @@ -224,6 +224,10 @@ pub fn default_config() -> Config { | |||
| /// Parse a database url into configuration that can be used to start a pool. | |||
| pub fn url_config(database_url: String) -> Result(Config, Nil) { | |||
| use uri <- result.then(uri.parse(database_url)) | |||
| let uri = case uri.port { | |||
| Some(_) -> uri | |||
| None -> Uri(..uri, port: Some(default_config().port)) | |||
There was a problem hiding this comment.
Rather than building the default config and then accessing the port let's move the default port to a private const and reference that in both places.
There was a problem hiding this comment.
Yes, I will make this change and update the changelog shortly.
There was a problem hiding this comment.
I've made this change and updated the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This is my first PR to this repo, please let me know if I missed anything. I wasn't sure if I should add this to the changelog.