-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Version Management (without sharing modes) #111
Conversation
packages/server/src/main/services/diagram-service/diagram-service.ts
Outdated
Show resolved
Hide resolved
packages/webapp/src/main/components/apollon-editor-component/ApollonEditorComponent.tsx
Outdated
Show resolved
Hide resolved
packages/webapp/src/main/components/version-management-sidebar/version-management-sidebar.tsx
Outdated
Show resolved
Hide resolved
…t in ApollonEditorComponent
…lon_standalone into feature/version-management
@farisd16 I found an edge case while testing
Screen.Recording.2024-11-07.at.22.32.30.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code and I tested in my local, looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me but after testing the functionality on https://test1.apollon.ase.in.tum.de/ I still found some minor issues.
If I delete a version and then move an element the version will reappear.
Some views need to be adjusted for dark mode, I think they need a dark background with light text:
Also, the current unpublished version never disappears. I think until there are no changes it should select the published version and not show current unpublished version
.
The current unpublished version
also does not have the dot to show that it is selected/active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me and the functionality is now as expected. Thank you for implementing that feature!
Description
This PR adds version management as described in #97, with two exceptions:
This avoids breaking changes because no existing fields are removed and only new fields are added. A diagram with two versions can then for example look like this:
Steps for Testing