Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker compose #114

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Fix docker compose #114

merged 3 commits into from
Nov 29, 2024

Conversation

farisd16
Copy link
Member

This PR fixes the failing build that occurs when trying to start Apollon standalone with docker compose.

@farisd16 farisd16 added the bug Something isn't working label Nov 28, 2024
@farisd16 farisd16 self-assigned this Nov 28, 2024
@farisd16 farisd16 changed the title Bugfix/fix docker compose Fix docker compose Nov 28, 2024
FelixTJDietrich
FelixTJDietrich approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned the dependencies and ran npm install. Code LGTM and the docker compose works for me

@FelixTJDietrich FelixTJDietrich merged commit 89fb800 into main Nov 29, 2024
1 of 2 checks passed
@FelixTJDietrich FelixTJDietrich deleted the bugfix/fix-docker-compose branch November 29, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixTJDietrich FelixTJDietrich FelixTJDietrich approved these changes

Assignees

@farisd16 farisd16

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farisd16 @FelixTJDietrich