Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add annotation to disable thread group check #378

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bensofficial
Copy link
Member

Problem

When testing JavaFX exercises with TestFX, the tests fail because TestFX spawns additional threads in the thread group. These threads are terminated during thread group validation, which disrupts the TestFX testing process.

Solution

Introduce a new optional annotation, @DisableThreadGroupCheck, that disables the thread group check when applied. This prevents the termination of threads spawned by TestFX, allowing the testing process to complete without interruptions.

You might have a look at how this is used for testing JavaFX exercises: https://github.com/bensofficial/javafx-example

@bensofficial bensofficial added enhancement New feature or request java Pull requests that update Java code labels Dec 11, 2024
@bensofficial bensofficial self-assigned this Dec 11, 2024
Hialus
Hialus previously approved these changes Dec 11, 2024
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Would be great if this is merged soon, so we can use it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants