Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectural: Add Wala Framework Setup #35

Merged
merged 48 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d8b74e1
Add Wala Framework Setup
sarpsahinalp Oct 21, 2024
18533d7
Merge branch 'main' into feature/wala-implementation
sarpsahinalp Oct 21, 2024
a0ba1d9
Updated archunit tests
sarpsahinalp Oct 28, 2024
c17e30b
Changes in class resolver
sarpsahinalp Oct 29, 2024
ead7c0c
Updated archunit tests
sarpsahinalp Oct 31, 2024
54da5b5
Fix thread creation stuff for archunit
sarpsahinalp Oct 31, 2024
9e49868
Update archunit and wala implementation
sarpsahinalp Oct 31, 2024
4dd34ef
Improve wala tests
sarpsahinalp Oct 31, 2024
f2c0515
Merge branch 'main' into feature/wala-implementation
Oct 31, 2024
a525684
Feedback addressed coderabbit
sarpsahinalp Oct 31, 2024
6762c4d
Changes
sarpsahinalp Nov 3, 2024
82bf8d6
Changes in class resolver
sarpsahinalp Nov 4, 2024
72cfc94
Refactoring of architectural tests
sarpsahinalp Nov 5, 2024
a0a18f1
Fix failing tests
sarpsahinalp Nov 12, 2024
b60311c
Merge remote-tracking branch 'origin/feature/wala-implementation' int…
sarpsahinalp Nov 12, 2024
e257cc2
Add Wala enum for the architecture mode
sarpsahinalp Nov 19, 2024
ee10233
1. Refactor and add a strategy pattern for dynamic allocation of the …
sarpsahinalp Nov 19, 2024
157e936
1. Implemented the test cases for WalaSecurityTestCases
sarpsahinalp Nov 20, 2024
094935e
1. Add german translation for reasons
sarpsahinalp Nov 21, 2024
fc60a59
Macos specific file methods
sarpsahinalp Nov 24, 2024
69ca695
Add linux methods
sarpsahinalp Nov 24, 2024
2335c97
Merge remote-tracking branch 'origin/feature/wala-implementation' int…
sarpsahinalp Nov 24, 2024
f01a37d
Add windows methods to analyze
sarpsahinalp Nov 24, 2024
6b95748
Add methods for Wala framework
sarpsahinalp Nov 24, 2024
824732a
1. Refactor methods, parse methods for Wala framework
sarpsahinalp Nov 25, 2024
3150e2a
Narrowed structural differences between AOP and Architecture
Nov 26, 2024
26b18a5
Narrowed structural differences between AOP and Architecture
Nov 26, 2024
e76c20f
Update src/main/resources/de/tum/cit/ase/ares/api/localization/messag…
sarpsahinalp Nov 26, 2024
aab978f
Update src/main/resources/de/tum/cit/ase/ares/api/localization/messag…
sarpsahinalp Nov 26, 2024
23cb0b3
Update src/main/java/de/tum/cit/ase/ares/api/architecture/Architectur…
sarpsahinalp Nov 26, 2024
eba498f
Update src/main/java/de/tum/cit/ase/ares/api/architecture/java/wala/J…
sarpsahinalp Nov 26, 2024
3b80a18
Improve error messages
sarpsahinalp Nov 26, 2024
934b429
Merge remote-tracking branch 'origin/feature/wala-implementation' int…
sarpsahinalp Nov 26, 2024
3e29c27
Add german translation
sarpsahinalp Nov 26, 2024
6eb557c
Refactoring
sarpsahinalp Nov 26, 2024
6cb9ec1
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
79c9c17
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
452dae9
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
3ced159
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
78d52ca
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
4950299
Narrowed structural differences between Versions of Architecture tests
Nov 26, 2024
536233d
Change file constant names
sarpsahinalp Nov 26, 2024
64c9a0c
Add localization in ReachabilityChecker
sarpsahinalp Nov 26, 2024
8b8880f
Change german messages to pass the tests
sarpsahinalp Nov 27, 2024
1aba388
Add comment functionality in text files
sarpsahinalp Nov 27, 2024
10df859
Add comment functionality in text files
sarpsahinalp Nov 27, 2024
013b0e7
Add tests for the wala framework fix changes
sarpsahinalp Nov 27, 2024
b7ae64b
Address the changes!
sarpsahinalp Nov 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@
<artifactId>byte-buddy-agent</artifactId>
<version>1.14.19</version>
</dependency>
<dependency>
<groupId>com.ibm.wala</groupId>
<artifactId>com.ibm.wala.core</artifactId>
<version>1.6.7</version>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down Expand Up @@ -591,7 +596,9 @@
<version>3.3.0</version>
<configuration>
<forkCount>1</forkCount>
<argLine>-javaagent:/home/sarps/IdeaProjects/Ares2/target/ares-2.0.0-SNAPSHOT-agent.jar -Xbootclasspath/a:${user.home}/.m2/repository/org/aspectj/aspectjrt/${aspectj.version}/aspectjrt-${aspectj.version}.jar</argLine>
<argLine>-javaagent:/home/sarps/IdeaProjects/Ares2/target/ares-2.0.0-SNAPSHOT-agent.jar
-Xbootclasspath/a:${user.home}/.m2/repository/org/aspectj/aspectjrt/${aspectj.version}/aspectjrt-${aspectj.version}.jar
</argLine>
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
</configuration>
</plugin>
</plugins>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
package de.tum.cit.ase.ares.api.architecture.java.wala;

import com.ibm.wala.classLoader.IClass;
import com.ibm.wala.classLoader.IMethod;
import com.ibm.wala.classLoader.Language;
import com.ibm.wala.core.util.config.AnalysisScopeReader;
import com.ibm.wala.ipa.callgraph.*;
import com.ibm.wala.ipa.callgraph.impl.DefaultEntrypoint;
import com.ibm.wala.ipa.callgraph.impl.Util;
import com.ibm.wala.ipa.callgraph.propagation.InstanceKey;
import com.ibm.wala.ipa.cha.ClassHierarchy;
import com.ibm.wala.ipa.cha.ClassHierarchyException;
import com.ibm.wala.ipa.cha.ClassHierarchyFactory;
import com.ibm.wala.types.ClassLoaderReference;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.BufferedWriter;
import java.io.FileWriter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

public class JavaWalaSecurityTestCase {

private static final Logger log = LoggerFactory.getLogger(JavaWalaSecurityTestCase.class);

public static CallGraph buildCallGraph() {
try {
// Create an AnalysisScope for the Java 21 JRT modules
AnalysisScope.createJavaAnalysisScope();
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
// get entire classpath of the project
String classpath = System.getProperty("java.class.path");
AnalysisScope scope = AnalysisScopeReader.instance.makeJavaBinaryAnalysisScope(
classpath,
null);

// Build the class hierarchy
ClassHierarchy chaWholeApplication = ClassHierarchyFactory.make(scope);

// Create a list to store entry points
List<Entrypoint> customEntryPoints = new ArrayList<>();

sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
// Create AnalysisOptions for call graph
AnalysisOptions options = new AnalysisOptions(scope, customEntryPoints);


// Create call graph builder (n-CFA, context-sensitive, etc.)
CallGraphBuilder<InstanceKey> builder = Util.makeZeroCFABuilder(Language.JAVA, options, new AnalysisCacheImpl(), chaWholeApplication);
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved

long startTime = System.currentTimeMillis();
// Generate the call graph
CallGraph callGraph = builder.makeCallGraph(options, null);
long endTime = System.currentTimeMillis();

log.info("Building call graph took {} ms", endTime - startTime);

List<CGNode> violatingMethods = ReachabilityChecker.isReachable(callGraph, callGraph.getEntrypointNodes().iterator(), node -> node.getMethod().getSignature().startsWith("sun.nio.fs.UnixFileSystemProvider") || node.getMethod().getSignature().startsWith("java.security.AccessController") || node.getMethod().getSignature().startsWith("java.lang.CLassLoader.findResource"));
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
log.info("Violating methods: {}", violatingMethods);
return callGraph;
} catch (IOException | CallGraphBuilderCancelException | ClassHierarchyException e) {
throw new SecurityException("Error building call graph", e); //$NON-NLS-1$
}
}

// Write the CallGraph to a DOT file
public static void writeCallGraphToDot(CallGraph callGraph, String filePath) throws IOException {
try (BufferedWriter writer = new BufferedWriter(new FileWriter(filePath))) {
writer.write("digraph G {\n");

// Iterate through the nodes in the call graph
for (CGNode node : callGraph) {
// Write the node representation
writer.write(" \"" + node.getMethod().getSignature() + "\";\n");

// Iterate through the edges (call sites) from the current node
for (Iterator<CGNode> it = callGraph.getSuccNodes(node); it.hasNext(); ) {
CGNode successor = it.next();
// Write the edge representation
writer.write(" \"" + node.getMethod().getSignature() + "\" -> \"" + successor.getMethod().getSignature() + "\";\n");
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
}
}
writer.write("}\n");
}
}

public static void main(String[] args) throws IOException {
CallGraph callGraph = buildCallGraph();
writeCallGraphToDot(callGraph, "callgraph.dot");
}
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package de.tum.cit.ase.ares.api.architecture.java.wala;

import com.ibm.wala.classLoader.IClass;
import com.ibm.wala.classLoader.IMethod;
import com.ibm.wala.ipa.callgraph.CGNode;
import com.ibm.wala.ipa.callgraph.CallGraph;
import com.ibm.wala.ipa.callgraph.impl.DefaultEntrypoint;
import com.ibm.wala.ipa.cha.ClassHierarchy;
import com.ibm.wala.types.ClassLoaderReference;
import com.ibm.wala.util.graph.traverse.DFSPathFinder;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.function.Predicate;

/**
* A utility class to check reachability in a call graph.
*/
class ReachabilityChecker {

private ReachabilityChecker() {
// Utility class
}
sarpsahinalp marked this conversation as resolved.
Show resolved Hide resolved

/**
* Checks if a target node is reachable from a set of start nodes in a call graph.
* @param callGraph The call graph to search in.
* @param startNodes The start nodes to search from.
* @param targetNodeFilter A filter to determine if a node is a target node.
* @return A list of nodes that are reachable from the start nodes and match the target node filter.
*/
public static List<CGNode> isReachable(CallGraph callGraph, Iterator<CGNode> startNodes, Predicate<CGNode> targetNodeFilter) {
// TODO: Implement our own pathfinder instead of the default
return new DFSPathFinder<>(callGraph, startNodes, targetNodeFilter).find();
}

// TODO: This is currently not working as expected!!!
public static List<DefaultEntrypoint> getEntryPointsFromStudentSubmission(CallGraph callGraph, Iterator<CGNode> startNodes, ClassHierarchy cha, ClassHierarchy chaClassPath) {
// Iterate through all classes in the application classloader
List<DefaultEntrypoint> customEntryPoints = new ArrayList<>();
for (IClass klass : cha) {
if (klass.getClassLoader().getReference().equals(ClassLoaderReference.Application)) {
// Iterate through all declared methods in each class
for (IMethod method : klass.getDeclaredMethods()) {
// Exclude the 'main' methods from being entry points
if (!method.getName().toString().equals("main")) {
customEntryPoints.add(new DefaultEntrypoint(method.getReference(), chaClassPath));
}
}
}
}
return customEntryPoints;
}
}