Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Architectural
: Add Wala Framework Setup #35Architectural
: Add Wala Framework Setup #35Changes from 27 commits
d8b74e1
18533d7
a0ba1d9
c17e30b
ead7c0c
54da5b5
9e49868
4dd34ef
f2c0515
a525684
6762c4d
82bf8d6
72cfc94
a0a18f1
b60311c
e257cc2
ee10233
157e936
094935e
fc60a59
69ca695
2335c97
f01a37d
6b95748
824732a
3150e2a
26b18a5
e76c20f
aab978f
23cb0b3
eba498f
3b80a18
934b429
3e29c27
6eb557c
6cb9ec1
79c9c17
452dae9
3ced159
78d52ca
4950299
536233d
64c9a0c
8b8880f
1aba388
10df859
013b0e7
b7ae64b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Path resolution in FileHandlerConstants needs to be updated
The file paths referenced in FileHandlerConstants.java need to be updated to match the actual location of the files in the repository. The files exist but are located at
src/main/resources/de/tum/cit/ase/ares/api/templates/architecture/java/archunit/methods/
instead of the currently referencedtemplates/architecture/java/archunit/methods/
.FileHandlerConstants.java
to include the full path prefixde/tum/cit/ase/ares/api/
JAVA_FILESYSTEM_INTERACTION_METHODS
should resolve tode/tum/cit/ase/ares/api/templates/architecture/java/archunit/methods/file-system-access-methods.txt
🔗 Analysis chain
Verify ArchUnit method files existence and content
The paths look well-structured, but let's verify the resources.
Let me check if these files might exist in a different location or with slightly different names before making a final conclusion.
Let me check the content of one of these files to verify the Java-style signatures, as the files exist but in a different location than what's referenced in the constants.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 3247
Script:
Length of output: 5281
Script:
Length of output: 25663
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Standardization of method files is needed for consistency
The files exist but there are several inconsistencies that should be addressed:
File naming inconsistency:
thread-manipulation.txt
while ArchUnit usesthread-manipulation-methods.txt
reflection.txt
while ArchUnit usesreflection-methods.txt
Content structure differences:
Ljava/lang/String;
)java.lang.String
)Suggested changes:
🔗 Analysis chain
Standardize naming between ArchUnit and WALA constants.
There are inconsistencies in naming between corresponding ArchUnit and WALA constants:
JAVA_JVM_TERMINATION_METHODS
vsWALA_JVM_METHODS
JAVA_THREAD_MANIPULATION_METHODS
vsWALA_THREAD_MANIPULATION_METHODS
Consider standardizing the names for better maintainability:
The WALA method files exist but at a different path than checked initially
The previous review comment about naming inconsistencies is valid, but there's a more important issue to address. The files exist at
src/main/resources/de/tum/cit/ase/ares/api/templates/architecture/java/wala/methods/
instead of the path used in the constants. TheFileTools.resolveOnResources()
method should be able to handle this, but we should verify its implementation.WALA_JVM_METHODS
vsJAVA_JVM_TERMINATION_METHODS
naming inconsistency existsWALA_THREAD_MANIPULATION_METHODS
vsthread-manipulation.txt
file name inconsistency exists🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 3706
Script:
Length of output: 8259
Script:
Length of output: 3476
Script:
Length of output: 38715