Fix IT tests: check exception cause message #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfr2102
commented
Dec 16, 2024
| @@ -33,13 +33,13 @@ public JwtDecoder jwtDecoder(SecurityMetersService metersService) { | |||
| try { | |||
| return jwtDecoder.decode(token); | |||
| } catch (Exception e) { | |||
| if (e.getMessage().contains("Invalid signature")) { | |||
| if (exceptionCauseContains(e, "Invalid signature")) { | |||
| metersService.trackTokenInvalidSignature(); | |||
| } else if (e.getMessage().contains("Jwt expired at")) { | |||
There was a problem hiding this comment.
in the case of expired token no cause, check directly in message as before
|
I think I was able to fix the tests. The error message changed, probably after a dependency update. I added a new condition to include the new error message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the integration tests are failing since a while: https://github.com/ls1intum/Artemis-Benchmarking/actions/workflows/ci.yml
fixing test cases in TokenAuthenticationSecurityMetersIT.java