Skip to content

Commit

Permalink
fix broken basic approach
Browse files Browse the repository at this point in the history
  • Loading branch information
= Enea_Gore committed Oct 25, 2024
1 parent 8de54ab commit 95e8492
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion modules/text/module_text_llm/module_text_llm/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ def process_incoming_feedback(exercise: Exercise, submission: Submission, feedba
async def suggest_feedback(exercise: Exercise, submission: Submission, is_graded: bool, module_config: Configuration) -> List[Feedback]:
logger.info("suggest_feedback: %s suggestions for submission %d of exercise %d were requested",
"Graded" if is_graded else "Non-graded", submission.id, exercise.id)
logger.info("WHAAAAA module_config: %s", type(module_config.approach))
return await generate_suggestions(exercise, submission, module_config.approach, module_config.debug)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,14 @@ class FeedbackModel(BaseModel):
description="ID of the grading instruction that was used to generate this feedback, or empty if no grading instruction was used"
)

class Config:
title = "Feedback"


class AssessmentModel(BaseModel):
"""Collection of feedbacks making up an assessment"""

feedbacks: List[FeedbackModel] = Field(description="Assessment feedbacks")

class Config:
title = "Assessment"


async def generate_suggestions(exercise: Exercise, submission: Submission, config: BasicApproachConfig, debug: bool) -> List[Feedback]:
model = config.model.get_model() # type: ignore[attr-defined]
logger.warning("Doing basic")

prompt_input = {
"max_points": exercise.max_points,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class InitialAssessmentModel(BaseModel):

async def generate_suggestions(exercise: Exercise, submission: Submission, config: ChainOfThoughtConfig, debug: bool) -> List[Feedback]:
model = config.model.get_model() # type: ignore[attr-defined]
logger.warning("Doing chain of thught ")

prompt_input = {
"max_points": exercise.max_points,
Expand Down

0 comments on commit 95e8492

Please sign in to comment.