Remove all unused images on cleanup, not just dangling ones #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
deployment-error
pal03377
added
deploy:athena-test1
github-actions
bot
added
lock:athena-test1
pal03377
temporarily deployed
to
Athena Test Server 3
GitHub Actions
Inactive
pal03377
removed
the
lock:athena-test1
|
I'm merging this directly because it works and it's very valuable to have right away |
|
Thanks @pal03377! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The test server disk space got full because non-dangling Docker images were not removed.
Description
Change the existing Docker cleanup (after TS deployment) to also remove non-dangling images.
Steps for Testing
Deploy to the test server. Then, observe how old images are removed and there won't be a disk space problem for a longer time span.
Screenshots
I manually executed the cleanup command to test:
