Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module_text_llm: Upgrade dependencies and openai model retrieval #323

Merged
merged 16 commits into from
Aug 5, 2024
Merged

Module_text_llm: Upgrade dependencies and openai model retrieval #323

merged 16 commits into from
Aug 5, 2024

Conversation

EneaGore
Copy link
Contributor

@EneaGore EneaGore commented Jul 31, 2024 •
edited
Loading

Note

ENVIRONMENT for text llm has been changed.

Motivation and Context

Major updates for langchain and openai.

Description

This PR updates the dependencies of the module_text_llm to the latest version. Namely openai 1.37.1 and langcahin 0.2.11

Steps for Testing

Screenshots

@EneaGore EneaGore changed the title Text_module_llm Upgrade dependencies and openai model retrieval Module_text_llm Upgrade dependencies and openai model retrieval Jul 31, 2024
@EneaGore EneaGore added the deploy:athena-test1 Athena Test Server 1 label Jul 31, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Jul 31, 2024
@EneaGore EneaGore temporarily deployed to Athena Test Server 1 July 31, 2024 19:03 — with GitHub Actions Inactive
@EneaGore EneaGore marked this pull request as ready for review July 31, 2024 19:09
@EneaGore EneaGore added deploy:athena-test1 Athena Test Server 1 and removed lock:athena-test1 Is currently deployed to Athena Test Server 1 labels Jul 31, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Jul 31, 2024
@EneaGore EneaGore temporarily deployed to Athena Test Server 1 July 31, 2024 19:42 — with GitHub Actions Inactive
@FelixTJDietrich FelixTJDietrich self-requested a review July 31, 2024 20:28
@FelixTJDietrich FelixTJDietrich changed the title Module_text_llm Upgrade dependencies and openai model retrieval Module_text_llm: Upgrade dependencies and openai model retrieval Aug 1, 2024
FelixTJDietrich
FelixTJDietrich requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the playground:
image

Here are some comments. The important part is getting the deployments dynamically. After you're done I can also do a follow-up PR to do some refactoring, I also have some ideas how to can be more maintainable for the future

module_text_llm/pyproject.toml Outdated Show resolved Hide resolved
module_text_llm/pyproject.toml Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
@EneaGore EneaGore added deploy:athena-test1 Athena Test Server 1 and removed lock:athena-test1 Is currently deployed to Athena Test Server 1 labels Aug 4, 2024
@github-actions github-actions bot removed the deploy:athena-test1 Athena Test Server 1 label Aug 4, 2024
@github-actions github-actions bot added the lock:athena-test1 Is currently deployed to Athena Test Server 1 label Aug 4, 2024
@EneaGore EneaGore temporarily deployed to Athena Test Server 1 August 4, 2024 19:14 — with GitHub Actions Inactive
FelixTJDietrich
FelixTJDietrich requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far :)
I will test the functionality soon

module_text_llm/.env.example Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/.env.example Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
module_text_llm/module_text_llm/helpers/models/openai.py Outdated Show resolved Hide resolved
@EneaGore EneaGore added deploy:athena-test1 Athena Test Server 1 and removed lock:athena-test1 Is currently deployed to Athena Test Server 1 labels Aug 5, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Aug 5, 2024
@EneaGore EneaGore temporarily deployed to Athena Test Server 1 August 5, 2024 09:52 — with GitHub Actions Inactive
@FelixTJDietrich
Copy link
Collaborator

FelixTJDietrich commented Aug 5, 2024 •
edited
Loading

Other than the one thing this PR is ready to merge, I also tested it on the playground and it works as expected. I verified it over my LangSmith instance and the right models were called.

FelixTJDietrich
FelixTJDietrich approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTJDietrich FelixTJDietrich merged commit accdabc into develop Aug 5, 2024
11 of 12 checks passed
@FelixTJDietrich FelixTJDietrich deleted the chore/update-llm-module branch August 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixTJDietrich FelixTJDietrich FelixTJDietrich approved these changes

Assignees
No one assigned
Labels
lock:athena-test1 Is currently deployed to Athena Test Server 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EneaGore @FelixTJDietrich