Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_modeling_LLM: Fix the handling of BPMN diagrams without pools #326

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

LeonWehrhahn
Copy link
Contributor

@LeonWehrhahn LeonWehrhahn commented Aug 5, 2024

Motivation and Context

The change is required to fix an issue in the BPMNSerializer where BPMN diagrams without pools were not being serialized. This caused the diagrams to not be added correctly to the prompt, resulting in wrong feedback on BPMN diagram submissions.

Description

Modified the BPMNSerializer to handle elements without pools by assigning them to a default unnamed pool.

Steps for Testing

Use the Playground to:

  • Test with the "Pizza Delivery" example, which initially had issues due to the lack of pools, and ensure that all elements are correctly serialized and the LLM provides relevant feedback.
  • Use the "Obtaining a Loan" example, which includes pools, to confirm it still works as expected.

@maximiliansoelch maximiliansoelch changed the title Fix - Handle BPMN diagrams without pools module_modeling_LLM: Fix the handling of BPMN diagrams without pools Aug 6, 2024
@maximiliansoelch maximiliansoelch added the deploy:athena-test1 Athena Test Server 1 label Aug 6, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Aug 6, 2024
@maximiliansoelch maximiliansoelch temporarily deployed to Athena Test Server 1 August 6, 2024 10:44 — with GitHub Actions Inactive
Copy link
Member

@maximiliansoelch maximiliansoelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1, feedback is now also generated for models without a pool.
Code looks good 👍

@maximiliansoelch maximiliansoelch merged commit 31ca477 into develop Aug 6, 2024
17 of 18 checks passed
@maximiliansoelch maximiliansoelch deleted the fix/bpmn-serializer branch August 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lock:athena-test1 Is currently deployed to Athena Test Server 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants