Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAI model configuration #327

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Aug 5, 2024

Motivation and Context

While deploying wen noticed that hardcoding the deployments was not ideal. Also gpt-4o was not selectable for OpenAI.

Description

  • Fix OpenAI models
  • Remove hardcoded Azure deployments
  • Use old Azure API to fetch deployments, once it breaks we will migrate

Steps for Testing

Check if TextLLM still works in the playground.

Screenshots

image

@FelixTJDietrich FelixTJDietrich self-assigned this Aug 5, 2024
@FelixTJDietrich FelixTJDietrich added python Pull requests that update Python code enhancement New feature or request labels Aug 5, 2024
@FelixTJDietrich FelixTJDietrich added the deploy:athena-test1 Athena Test Server 1 label Aug 6, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Aug 6, 2024
@FelixTJDietrich FelixTJDietrich temporarily deployed to Athena Test Server 1 August 6, 2024 06:18 — with GitHub Actions Inactive
@FelixTJDietrich
Copy link
Collaborator Author

Checked on TS1 and it works. I also changed the env on the TS1

@FelixTJDietrich FelixTJDietrich merged commit 7ae325c into develop Aug 6, 2024
29 of 30 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/fix-openai-model-configuration branch August 6, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lock:athena-test1 Is currently deployed to Athena Test Server 1 python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant