Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Selectable Approaches for Text (Chain of Thought with Prompt Chaining) #350

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

EneaGore
Copy link
Contributor

@EneaGore EneaGore commented Oct 24, 2024

Motivation and Context

This PR provides a new structure for different approaches within the text llm module. It already adds a new approach "chain of thought".

Description

The standard approach has been moved in a folder named basic_approach. Each approach has its own folder so they can be easily added, or deleted in case it is not needed anymore. The approach controller and config need to be adjusted when a new approach is added or removed.

Steps for Testing

  1. Select text llm module
  2. Observe the new approach selector, pick either one.
  3. Confirm that the request is processed and that the correct one was called (either use langsmith locally or see that, for example, in the case of chain of thought with chain prompting there are 2 llm calls in the meta data output)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.


Screenshots

@EneaGore EneaGore added the deploy:athena-test2 Athena Test Server 2 label Oct 24, 2024
@EneaGore EneaGore changed the title mvp multiple approaches and cot mvp multiple approaches and cot WIP Oct 24, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 24, 2024 01:05 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 24, 2024
@maximiliansoelch maximiliansoelch removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Oct 24, 2024
@EneaGore EneaGore added the deploy:athena-test2 Athena Test Server 2 label Oct 25, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 25, 2024 01:27 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 25, 2024
@EneaGore EneaGore removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Oct 25, 2024
@EneaGore EneaGore added the deploy:athena-test2 Athena Test Server 2 label Oct 30, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 30, 2024 02:15 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 30, 2024
@EneaGore EneaGore removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Oct 30, 2024
@EneaGore EneaGore marked this pull request as ready for review November 17, 2024 03:01
@EneaGore EneaGore changed the title mvp multiple approaches and cot WIP Multiple Selectable Approaches for Text (Chain of Thought) Nov 18, 2024
@EneaGore EneaGore changed the title Multiple Selectable Approaches for Text (Chain of Thought) Multiple Selectable Approaches for Text (Chain of Thought with Prompt Chaining) Nov 18, 2024
@EneaGore EneaGore added the deploy:athena-test2 Athena Test Server 2 label Nov 28, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de November 28, 2024 11:30 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Nov 28, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure and code looks good now.

We will have to fix the playground issue in a follow-up

@FelixTJDietrich FelixTJDietrich merged commit 7cd213a into develop Nov 29, 2024
22 of 23 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/chain-of-thought branch November 29, 2024 16:18
@github-actions github-actions bot removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Nov 29, 2024
@EneaGore EneaGore mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants