Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: add minor Side-by-Side tool improvements #377

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

laadvo
Copy link
Contributor

@laadvo laadvo commented Dec 10, 2024

Motivation and Context

After looking over and using the Side-by-Side tool, a few possible improvements were suggested:

  1. Making the Title of the following exercise bold in the exercise window (opens whenever the exercise changes)
  2. Using mp4s instead of gifs in the tutorial
  3. Adding new line to the submission whenever a new feedback is referencing

Description

This PR implements the first two suggested changes. The exercise titles are now bold and in the tutorial videos are used. When trying to implement the third suggestion, it proved to be a lot more challenging than enticipating. Whenever a new line needs to be added to the submissions, it means that the lines being referenced by the other feedbacks need to be updated, resulting in a lot of overhead when wanting the feedbacks to still be displayed bellow the referenced lines. Additionally, it resulted in weird formating, making the submission more difficult to read, since for example sometimes feedbacks by mistake stop referencing it in the middle of a word.

Steps for Testing

  1. In Playground select Evaluation Mode and scroll down to Expert Evaluation
  2. Select an existing evaluation or create a new one with at least 2 exercises (create, save, start it, add an expert link)
  3. Access the expert link and make sure the tutorial steps are videos and no longer gifs
  4. Click your way through the evaluation so that you arrive at a new exercise
  5. You should see the Exercise window with exercise title in bold

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.


Screenshots

Gifs replaces by Videos in the tutorial:
image

Bold exercise title:
image

@laadvo laadvo marked this pull request as ready for review December 10, 2024 08:48
@DominikRemo DominikRemo self-requested a review December 10, 2024 16:56
@maximiliansoelch maximiliansoelch added the deploy:athena-test2 Athena Test Server 2 label Dec 13, 2024
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Dec 13, 2024
@DominikRemo DominikRemo removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Dec 16, 2024
@maximiliansoelch maximiliansoelch merged commit 779bac6 into develop Dec 16, 2024
32 checks passed
@maximiliansoelch maximiliansoelch deleted the small-side-by-side-tool-improvements branch December 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants