-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module config for module_example
and module_text_llm
#44
Conversation
module_example
and module_text_llm
The error you experienced with my module is still on my todo list. I will replace CSV parsing through JSON parsing and improve error handling so this does not happen anymore :S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! I only have larger problems in request_to_module.py
left now. I also tested it locally again.
Also, I notice that endpoints.py
is getting more and more complex (which is not really your fault). We might need to think of some refactoring in the future.
assessment_module_manager/assessment_module_manager/module/request_to_module.py
Outdated
Show resolved
Hide resolved
assessment_module_manager/assessment_module_manager/module/request_to_module.py
Outdated
Show resolved
Hide resolved
assessment_module_manager/assessment_module_manager/module/request_to_module.py
Outdated
Show resolved
Hide resolved
assessment_module_manager/assessment_module_manager/module/request_to_module.py
Outdated
Show resolved
Hide resolved
assessment_module_manager/assessment_module_manager/module/request_to_module.py
Show resolved
Hide resolved
playground/src/components/module_requests/request_feedback_suggestions.tsx
Show resolved
Hide resolved
playground/src/components/module_requests/request_submission_selection.tsx
Outdated
Show resolved
Hide resolved
…uest_to_module.py Co-authored-by: Paul Schwind <[email protected]>
…ture/llm-config
Co-authored-by: Paul Schwind <[email protected]>
Co-authored-by: Paul Schwind <[email protected]>
…uest_to_module.py Co-authored-by: Paul Schwind <[email protected]>
Co-authored-by: Paul Schwind <[email protected]>
… into feature/llm-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good & I tested it again locally. Thanks for the contribution, very cool changes! I'll merge it right now
Motivation and Context
We cant to test out multiple module configurations mostly for evaluation purposes, but it can also be used by the LMS to have some more control over the module. For my llm modules I want to be able to configure multiple approaches, multiple LLMs, and also prompts for the LLMs.
Another thing is that we might want to configure the module to be in debug mode or evaluation mode and send back debug data or evaluation data. For example for the LLMs, we would like to track the token usage, or the exact prompts used, etc.
Description
Small illustration
List of changes
config_schema_provider
decorator toathena
(GET/config_schema
endpoint for module sending back possible config options)assessment_module_manager
to modulesconfig_schema_provider
tomodule_example
module_example
not run/config_schema
request inModule Requests
asGet Config Schema
react-jsonschema-forms
in theBaseInfoHeader
(it tries to render the schema if it is found, config component can be customized)module_example
module_llm_text
to support azure and non-azure credentials at the same timeconfig_schema_provider
tomodule_text_llm
monaco
editor)module_text_llm
emit_meta
andget_meta
toathena
and include the emitted metadata with the request responseSteps for Testing
Prerequisites:
Update environment variables for
module_text_llm
or alternatively usemodule_example
for testing, but it is less cool.module_text_llm
in the BaseInfoHeaderScreenshots
Screenshot cut off....