fix: transient value error

ls1intum · Aug 20, 2024 · 45a6140 · 45a6140
1 parent 28c226c
commit 45a6140
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 21 deletions.
diff --git a/...lication-server/src/main/java/de/tum/in/www1/hephaestus/codereview/CodeReviewService.java b/...lication-server/src/main/java/de/tum/in/www1/hephaestus/codereview/CodeReviewService.java
@@ -49,7 +49,7 @@ public Repository getHephaestusRepository() {
                 example.setName("hephaestus");
                 example.setNameWithOwner("ls1intum/hephaestus");
                 Optional<Repository> foundRepo = codeReviewRepository.findOne(Example.of(example));
-                logger.info("All repositories: " + codeReviewRepository.findAll().toString());
+                logger.info("Repository count: " + codeReviewRepository.count());
 
                 logger.info("Saved repo: " + foundRepo.toString());
                 if (foundRepo.isPresent()) {
@@ -75,7 +75,8 @@ public Repository getHephaestusRepository() {
                 repository.setAddedAt(Instant.now());
 
                 System.out.println("Repository: " + repository.toString());
-                codeReviewRepository.save(repository);
+                codeReviewRepository.saveAndFlush(repository);
+                System.out.println("New Repository count: " + codeReviewRepository.count());
                 return repository;
         }
 

diff --git a/...er/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java b/...er/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
@@ -9,7 +9,6 @@
 import de.tum.in.www1.hephaestus.codereview.pullrequest.Pullrequest;
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
-import jakarta.persistence.FetchType;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.OneToMany;
@@ -45,12 +44,12 @@ public class Actor {
     /**
      * The Pullrequests of the User entity.
      */
-    @OneToMany(mappedBy = "author", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "author")
     private List<Pullrequest> pullrequests;
 
     /**
      * The Comments of the User entity.
      */
-    @OneToMany(mappedBy = "author", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "author")
     private List<Comment> comments;
 }
diff --git a/...pplication-server/src/main/java/de/tum/in/www1/hephaestus/codereview/comment/Comment.java b/...pplication-server/src/main/java/de/tum/in/www1/hephaestus/codereview/comment/Comment.java
@@ -10,6 +10,7 @@
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.JoinColumn;
 import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToOne;
 import lombok.Getter;
 import lombok.Setter;
 
@@ -57,9 +58,9 @@ public class Comment {
     private Actor author;
 
     /**
-     * The pullrequest of the Comment entity.
+     * The parent connection to the pullrequest of the Comment entity.
      */
-    @ManyToOne(fetch = FetchType.LAZY)
+    @OneToOne(optional = false)
     @JoinColumn(name = "c_connection_id", referencedColumnName = "id")
     private CommentConnection connection;
 

diff --git a/...-server/src/main/java/de/tum/in/www1/hephaestus/codereview/comment/CommentConnection.java b/...-server/src/main/java/de/tum/in/www1/hephaestus/codereview/comment/CommentConnection.java
@@ -2,14 +2,11 @@
 
 import java.util.List;
 
-import de.tum.in.www1.hephaestus.codereview.pullrequest.Pullrequest;
 import jakarta.persistence.Entity;
-import jakarta.persistence.FetchType;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.Id;
 import jakarta.persistence.OneToMany;
-import jakarta.persistence.OneToOne;
 import jakarta.persistence.Table;
 import lombok.Getter;
 import lombok.Setter;
@@ -23,6 +20,6 @@ public class CommentConnection {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    @OneToMany(mappedBy = "connection", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "connection")
     private List<Comment> nodes;
 }
diff --git a/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/Pullrequest.java b/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/Pullrequest.java
@@ -1,12 +1,10 @@
 package de.tum.in.www1.hephaestus.codereview.pullrequest;
 
-import java.time.Instant;
-
 import de.tum.in.www1.hephaestus.codereview.actor.Actor;
 import de.tum.in.www1.hephaestus.codereview.comment.CommentConnection;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
-import jakarta.persistence.Transient;
+import jakarta.persistence.CascadeType;
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.FetchType;
@@ -85,11 +83,14 @@ public class Pullrequest {
     /**
      * The comments of the Pullrequest entity.
      */
-    @OneToOne(optional = false)
+    @OneToOne(cascade = CascadeType.ALL, optional = false)
     @JoinColumn(name = "c_connection_id", referencedColumnName = "id")
     private CommentConnection comments;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    /**
+     * The parent connection of the Pullrequest entity.
+     */
+    @OneToOne(optional = false)
     @JoinColumn(name = "pr_connection_id", referencedColumnName = "id")
     private PullrequestConnection connection;
 }
diff --git a/...src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullrequestConnection.java b/...src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullrequestConnection.java
@@ -2,13 +2,10 @@
 
 import java.util.List;
 
-import de.tum.in.www1.hephaestus.codereview.repository.Repository;
 import jakarta.persistence.Id;
 import jakarta.persistence.OneToMany;
-import jakarta.persistence.OneToOne;
 import jakarta.persistence.Table;
 import jakarta.persistence.Entity;
-import jakarta.persistence.FetchType;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import lombok.Getter;
@@ -23,6 +20,6 @@ public class PullrequestConnection {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    @OneToMany(mappedBy = "connection", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "connection")
     private List<Pullrequest> nodes;
 }
diff --git a/...tion-server/src/main/java/de/tum/in/www1/hephaestus/codereview/repository/Repository.java b/...tion-server/src/main/java/de/tum/in/www1/hephaestus/codereview/repository/Repository.java
@@ -3,6 +3,7 @@
 import java.time.Instant;
 
 import de.tum.in.www1.hephaestus.codereview.pullrequest.PullrequestConnection;
+import jakarta.persistence.CascadeType;
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
@@ -42,7 +43,7 @@ public class Repository {
     @Column
     private String url;
 
-    @OneToOne(optional = false)
+    @OneToOne(cascade = CascadeType.ALL, optional = false)
     @JoinColumn(name = "connection_id", referencedColumnName = "id")
     private PullrequestConnection pullRequests;