move type and remove unnecessary JSON

ls1intum · Aug 13, 2024 · f691449 · f691449
1 parent fbe699b
commit f691449
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/webapp/src/app/@types/github.d.ts b/webapp/src/app/@types/github.d.ts
@@ -0,0 +1,10 @@
+export namespace GitHub {
+  export interface Contributor {
+    id: number;
+    login: string;
+    url: string;
+    html_url: string;
+    avatar_url: string;
+    // More fields can be added here
+  }
+}
diff --git a/webapp/src/app/about/about.component.ts b/webapp/src/app/about/about.component.ts
@@ -6,14 +6,7 @@ import { AvatarComponent } from 'app/ui/avatar/avatar.component';
 import { AvatarImageComponent } from 'app/ui/avatar/avatar-image.component';
 import { AvatarFallbackComponent } from 'app/ui/avatar/avatar-fallback.component';
 import { ButtonComponent } from 'app/ui/button/button.component';
-
-interface Contributor {
-  id: number;
-  login: string;
-  url: string;
-  html_url: string;
-  avatar_url: string;
-}
+import { GitHub } from 'app/@types/github';
 
 @Component({
   selector: 'app-about',
@@ -26,7 +19,7 @@ export class AboutComponent {
 
   query = injectQuery(() => ({
     queryKey: ['contributors'],
-    queryFn: async () => lastValueFrom(this.http.get('https://api.github.com/repos/ls1intum/hephaestus/contributors')) as Promise<Contributor[]>,
+    queryFn: async () => lastValueFrom(this.http.get('https://api.github.com/repos/ls1intum/hephaestus/contributors')) as Promise<GitHub.Contributor[]>,
     gcTime: Infinity
   }));
 
@@ -46,6 +39,4 @@ export class AboutComponent {
     }
     return data.filter((contributor) => contributor.id !== 5898705);
   });
-
-  JSON = JSON;
 }