Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI for Custom Time Sliding Window in Leaderboard #105

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Sep 27, 2024

Motivation

After the introduction of sliding time windows on the server in #100, we now aim to provide an intuitive GUI on the client to navigate through the past weekly leaderboards.

Description

This PR introduces a FILTER-card for the leaderboard among smaller QoL improvements:

  • When the data is still available yet, we feature a new Skeleton-component with an artificial delay (1s) added on top to improve UX and display smooth transitions
  • A filter-card features a new Select-component for choosing the timeframe to be displayed in the leaderboard. A timeframe is defined as a calendar week (monday-sunday). The options consist of the current as well as the last 4 weeks.
  • The filter card is displayed to the left of the leaderboard or above it on small devices.

Screenshots (if applicable)

Screenshot 2024-09-27 173746
Screenshot 2024-09-27 175816

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added enhancement New feature or request client labels Sep 27, 2024
@GODrums GODrums self-assigned this Sep 27, 2024
@github-actions github-actions bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@milesha milesha self-requested a review October 1, 2024 10:42
milesha
milesha previously approved these changes Oct 1, 2024
Copy link
Contributor

@milesha milesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

webapp/src/app/home/leaderboard/filter/filter.component.ts Outdated Show resolved Hide resolved
milesha
milesha previously approved these changes Oct 1, 2024
Copy link
Contributor

@milesha milesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me 👍🏼

Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@FelixTJDietrich FelixTJDietrich merged commit 2bf309a into develop Oct 1, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the leaderboard-filter-timeframe branch October 1, 2024 14:20
@GODrums GODrums mentioned this pull request Oct 2, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants