Upgrade Storybook to 8.3.4 and fix theme-toggle

[GODrums]

Motivation

To avoid conflicts between Spartan's Storybook integration and ours, we should upgrade our version (8.2.9) to match theirs (8.3.4).

Description

Currently npm install gives a bunch of warning related to conflicting Storybook versions. Example:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @storybook/[email protected]
npm warn Found: [email protected]
npm warn node_modules/storybook
npm warn   dev storybook@"8.2.9" from the root project
npm warn   22 more (@storybook/addon-actions, ...)
npm warn

In addition, I added a adjusted the theme-toggle fix for the new Storybook version (tested on Chrome 129.0 & Firefox 131.0).

Testing

1. Optional: delete node_modules in /webapp
2. Execute npm install and check for errors or warning related to Storybook
3. Run npm run storybook and check if the Storybook's theme-toggle still works correctly

Checklist

General

• PR title is clear and descriptive
• PR description explains the purpose and changes
• Code follows project coding standards
• Self-review of the code has been done
• Changes have been tested locally

Client (if applicable)

• UI changes look good on all screen sizes and browsers
• No console errors or warnings
• User experience and accessibility have been tested
• Added Storybook stories for new components
• Components follow design system guidelines (if applicable)

[FelixTJDietrich]

The theme switcher looks broken to me:
https://66a8981a27ced8fef3190d41-xctiftuyge.chromatic.com/?path=/docs/components-core-themeswitcher--docs&globals=theme:dark

Is this just a Storybook issue?

[FelixTJDietrich]

Ah you mean you fixed the storybook theme switcher not the app theme switcher, but the app theme switcher does not work as expected in storybook. Maybe that is also not too important

[FelixTJDietrich]

Nevermind it works now