Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user auth using Keycloak #114

Merged
merged 16 commits into from
Oct 5, 2024
Merged

Add user auth using Keycloak #114

merged 16 commits into from
Oct 5, 2024

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Oct 5, 2024

Motivation

We need users, Keycloak offers good user management

Description

  • Use oauth2 resource server together with Keycloak
  • Refactor header and footer
  • Improve header for better responsiveness
  • Collapse "Request a feature" to icon and add tooltip on small window sizes
  • Improve responsiveness of leaderboard + add an error alert if an error occured

TODO in this PR

  • Add development Keycloak realm and users + admin account
  • Keycloak setup for production
    • I guess we will have one instance for all deployments, a production realm and maybe test server realms
  • Angular environment for Keycloak setup

Screenshots (if applicable)

image image

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@github-actions github-actions bot added client application-server feature size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 5, 2024
@github-actions github-actions bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 5, 2024
@FelixTJDietrich
Copy link
Collaborator Author

I looked over the code a few times and I think I got everything working, will merge now. If something is broken we will fix it in a follow-up. I want to test if the keycloak instance I setup works on develop :)

@FelixTJDietrich FelixTJDietrich merged commit e61a46c into develop Oct 5, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/keycloak branch October 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant