-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor data model and syncing + implement NATS consumer #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
application-server
feature
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Oct 13, 2024
FelixTJDietrich
changed the title
WIP: Refactor data model and syncing + implement NATS consumer
Refactor data model and syncing + implement NATS consumer
Oct 26, 2024
GODrums
reviewed
Oct 27, 2024
...a/de/tum/in/www1/hephaestus/gitprovider/pullrequest/github/GitHubPullRequestSyncService.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We will need most of the GitHub entities and properties eventually. Introducing them later will be a higher cognitive load and will lead to some migration issues.
Description
codereview
module togitprovider
(maybe there is an even better name)Issue
PullRequest
to be subclass ofIssue
Milestone
pull_request
payloads (TODO: process repos)issues
payloadspull_request_review
payloadspull_request_review_comment
payloadsissue_comment
payloadslabel
payloads?milestone
payloads?Screenshots (if applicable)
Checklist
General
Client (if applicable)
Server (if applicable)