Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve filter layout for mobile #120

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Oct 16, 2024

Motivation

On smaller screens (e.g. mobile) the leaderboard filters are sometimes outside of the viewing area.

Description

This PR gives the filter component more responsiveness for smaller screens.

Screenshots (if applicable)

Width <580px:
image
Width 580-1280px:
image

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added bug Something isn't working client labels Oct 16, 2024
@GODrums GODrums self-assigned this Oct 16, 2024
@github-actions github-actions bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 16, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make the container fit the subviews? There is a lot of whitespace to the side 🤔
image
image

@GODrums
Copy link
Collaborator Author

GODrums commented Oct 16, 2024

Can you also make the container fit the subviews? There is a lot of whitespace to the side 🤔

What testing setup did you use to get this whitespace? I can't seem to reproduce it at all.

@FelixTJDietrich
Copy link
Collaborator

FelixTJDietrich commented Oct 16, 2024

Ah okay, I was just checking Storybook 🤔 Then it's fine, but ideally it should behave similarly

@FelixTJDietrich
Copy link
Collaborator

But it also looks kind of like this in your PR screenshot
image

@FelixTJDietrich FelixTJDietrich merged commit d08c7f4 into develop Oct 16, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/repository-filter-layout branch October 16, 2024 09:35
@GODrums
Copy link
Collaborator Author

GODrums commented Oct 16, 2024

Ah okay, I was just checking Storybook 🤔 Then it's fine, but ideally it should behave similarly

So the reason why it's not limited in Storybook is because we use the Tailwind container to limit the max-width of our whole "page body".

But it also looks kind of like this in your PR screenshot

The image is exactly the "wrapping" break-point from flex-wrap. So if you add a few pixels of width, it will snap back into the same row. Looks like this then:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants