-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer notifications
: Slack bot with weekly post
#129
Conversation
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but I would not hardcode those values on the client side. Also added some improvement comments. But once they are implemented we can merge this PR.
...plication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
...plication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
Outdated
Show resolved
Hide resolved
webapp/src/app/home/leaderboard/filter/timeframe/timeframe.component.html
Outdated
Show resolved
Hide resolved
webapp/src/app/home/leaderboard/filter/timeframe/timeframe.component.html
Show resolved
Hide resolved
webapp/src/app/home/leaderboard/filter/timeframe/timeframe.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/app/home/leaderboard/filter/timeframe/timeframe.component.ts
Outdated
Show resolved
Hide resolved
…1intum/Hephaestus into developer-notifications-slack
...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/SlackMessageService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you
Motivation
One of our goals is to integrate Hephaestus into Artemis's workflows as seemlessly as possible. This includes providing developer notifications about results in the leaderboard. As the primary channel for communication in Artemis, we primarily focus on Slack here.
Description
This PR sets up the new Slack-Bot
HephaestusBot
for usage within our application-server:Screenshots (if applicable)
Example of the scheduled Slack message:
Checklist
General
Server (if applicable)