-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Review Score on User Profiles #167
Display Review Score on User Profiles #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor remarks. Regarding the static
ScoringService
idk if this will be problematic. I understand why you did it but maybe this is where we'd need a DTO conversion service so we can dependency inject the service 🤔
...plication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
Outdated
Show resolved
Hide resolved
...plication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
Outdated
Show resolved
Hide resolved
...r/application-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/ScoringService.java
Show resolved
Hide resolved
webapp/src/app/user/review-activity-card/review-activity-card.component.html
Outdated
Show resolved
Hide resolved
webapp/src/app/user/review-activity-card/review-activity-card.component.html
Show resolved
Hide resolved
...n/java/de/tum/in/www1/hephaestus/gitprovider/pullrequestreview/PullRequestReviewInfoDTO.java
Outdated
Show resolved
Hide resolved
...plication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
Show resolved
Hide resolved
...r/application-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/ScoringService.java
Outdated
Show resolved
Hide resolved
...r/application-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/ScoringService.java
Outdated
Show resolved
Hide resolved
...n/java/de/tum/in/www1/hephaestus/gitprovider/pullrequestreview/PullRequestReviewInfoDTO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me now, thanks for implementing the requested changes so quickly!
It also looks really good, I really like this addition 😄
Motivation
To provide a better insight into the score calculation, we want to display the score of individual reviews on a user's profile.
Solves task 2 of #159.
Description
This PR adapts the scoring logic:
ScoringService
PullRequestReview
orIssueComment
entitiesTasks
ScoringService
PullRequestReview
IssueComment
ScoringService
inLeaderboardService
ReviewActivityCard
Testing Instructions
TODO
Screenshots (if applicable)
Checklist
General
Client (if applicable)
Server (if applicable)