Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intelligence Service MVP Chat Interface #169
Intelligence Service MVP Chat Interface #169
Changes from 34 commits
723d3d3
a767111
aee2967
4da1bec
ae650a7
c7d9c01
404fa8b
6992fad
8e6518e
e3d7af9
fc41a8a
8ada388
0c18b83
ee20325
9cead8f
b73becf
8e561bb
0a3d017
20f555c
e186137
d8d04ba
9eca357
82ac250
9b8c3f0
338843f
b3a661a
46d1f0c
7daf291
30b64a9
a1470a7
20d1eb0
e4af9f6
ae370be
b959388
91007bc
7f3e20b
7aefd9d
6b602fa
67d66c4
c419390
219090f
ce1f95b
c7ba180
7ef9a41
f7c41d5
3ef7b80
3acd54c
ee21f79
74a72fc
5dfe8bc
2faceb2
f2b5d4c
f150136
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other components we try to go for Skeletons instead of Spinners since they are much easier on the eye in terms of layout shifts.
Try to integrate Skeletons in here too. You can pass the "loading"-state down to the individual components, which can then handle it themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GODrums
Sure, was thinking of it too - the only problem in this case is that i am not sure what I need to create a Skeleton for in this case: we have one view which is shown if there are no sessions yet and a completely different one for the actual chat interface. What should I then make a Skeleton for when in is "undecided", which view to show (the number of user sessions is loading)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I see your point here. I was a little confused about how the whole "fetching"-logic is fully contained in the
ChatComponent
.I would have thought of it this way (inspired by the way https://chatgpt.com/ works):
Maybe I'm overengineering this a little though, I think your approach is fine too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GODrums good idea! I would make an extra issue for this frontend improvement and come back to it in another PR then 👍🏼
Check failure on line 10 in webapp/src/app/chat/first-session-card/first-session-card.component.html
GitHub Actions / Code Quality Checks