Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings page to delete user #182

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Nov 19, 2024

Motivation

We need to let users delete their account to be compliment with GDPR.

Description

  • Add setting page
  • Add setting button to user menu
  • Add endpoint to delete user (currently just the keycloak user)
  • Fix void response for OpenAPI
  • Update default keycloak config data with a correctly setup admin client

Testing Instructions

Create an account and delete it via the settings.

Screenshots (if applicable)

image image image

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@github-actions github-actions bot added client application-server size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@FelixTJDietrich FelixTJDietrich marked this pull request as ready for review November 19, 2024 23:42
@FelixTJDietrich FelixTJDietrich merged commit 4131054 into develop Nov 20, 2024
6 of 7 checks passed
@FelixTJDietrich FelixTJDietrich deleted the chore/delete-user branch November 20, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant